Skip to content

feat: add color question type #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

feat: add color question type #2748

merged 1 commit into from
Jun 25, 2025

Conversation

Chartman123
Copy link
Collaborator

@Chartman123 Chartman123 commented May 18, 2025

This closes #1617

Create view:
image

Submit view:
image
image

Results view:
image
image

@Chartman123 Chartman123 added enhancement New feature or request 3. to review Waiting for reviews feature: ❓ question types labels May 18, 2025
@Chartman123 Chartman123 self-assigned this May 18, 2025
@Chartman123 Chartman123 requested a review from hamza221 May 18, 2025 19:15
@Chartman123 Chartman123 added this to the 5.2 milestone May 18, 2025
Copy link

codecov bot commented May 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.54%. Comparing base (3adb419) to head (a138e01).
Report is 17 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2748      +/-   ##
============================================
+ Coverage     45.48%   45.54%   +0.06%     
- Complexity      987      990       +3     
============================================
  Files            79       79              
  Lines          3586     3590       +4     
============================================
+ Hits           1631     1635       +4     
  Misses         1955     1955              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Chartman123 Chartman123 force-pushed the feat/question-type-color branch 2 times, most recently from 93aad5d to 228553e Compare May 18, 2025 19:27
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems nice! :) I'm just not sure about showing the Hex code (at least directly) as that is very nerdy. Would be nicer to have the color boxes on the left so they are all aligned.

@jancborchardt
Copy link
Member

Also cc @raxp122 for review since they requested the feature. :)

@Chartman123
Copy link
Collaborator Author

@jancborchardt thanks for the review. I'll then turn the color box and the hex code around. I think it should be visible so that you can copy/paste the value. In the csv/spreadsheet export it will also only be the text representation as this is how we store it.

@Chartman123 Chartman123 force-pushed the feat/question-type-color branch 3 times, most recently from 6548b84 to 184e61d Compare May 19, 2025 15:06
@Chartman123 Chartman123 force-pushed the feat/question-type-color branch 2 times, most recently from a9dbb12 to 848a5b4 Compare June 1, 2025 14:20
@raxp122
Copy link

raxp122 commented Jun 1, 2025

It looks so nice, how can i test this?

@Chartman123
Copy link
Collaborator Author

Chartman123 commented Jun 2, 2025

@raxp122 thanks for your feedback :) Do you have a test instance? If not, I don't recommend testing it on your prod environment.

  • You can download the files of this Pull Request here: forms.tar.gz
  • Unzip it and move the extracted files into your apps folder replacing your current forms directory.
  • You will then also get all the other changes already merged for the upcoming 5.2 release
  • Beware that this will change your database: Make a backup of your database and your forms directory

Signed-off-by: Christian Hartmann <[email protected]>
@Chartman123 Chartman123 force-pushed the feat/question-type-color branch from 848a5b4 to a138e01 Compare June 23, 2025 08:33
@Chartman123 Chartman123 merged commit c70801a into main Jun 25, 2025
54 checks passed
@Chartman123 Chartman123 deleted the feat/question-type-color branch June 25, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: ❓ question types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color picker, color presets
4 participants