-
Notifications
You must be signed in to change notification settings - Fork 105
feat: add color question type #2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
============================================
+ Coverage 45.48% 45.54% +0.06%
- Complexity 987 990 +3
============================================
Files 79 79
Lines 3586 3590 +4
============================================
+ Hits 1631 1635 +4
Misses 1955 1955 🚀 New features to boost your workflow:
|
93aad5d
to
228553e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems nice! :) I'm just not sure about showing the Hex code (at least directly) as that is very nerdy. Would be nicer to have the color boxes on the left so they are all aligned.
Also cc @raxp122 for review since they requested the feature. :) |
@jancborchardt thanks for the review. I'll then turn the color box and the hex code around. I think it should be visible so that you can copy/paste the value. In the csv/spreadsheet export it will also only be the text representation as this is how we store it. |
6548b84
to
184e61d
Compare
a9dbb12
to
848a5b4
Compare
It looks so nice, how can i test this? |
@raxp122 thanks for your feedback :) Do you have a test instance? If not, I don't recommend testing it on your prod environment.
|
Signed-off-by: Christian Hartmann <[email protected]>
848a5b4
to
a138e01
Compare
This closes #1617
Create view:

Submit view:


Results view:

